wevisdemo / parliament-watch

Citizens are watching 👀
https://parliamentwatch.wevis.info
47 stars 26 forks source link

Icyscools/#13 VoteOptionTag component #16

Closed Icyscools closed 11 months ago

Icyscools commented 11 months ago

Related to #13

Also, I remove an unused import and refactor a switch case to if-else and add styles for each option, so that we can remove the if (typeof voteOption === 'string') condition.

I think it can be improved this way since it doesn't have any string other than defined in the DefaultVoteOption enum, otherwise, it needs to be a CustomVoteOption as we discussed in the issue. But feel free to give it a comment. 😄

Icyscools commented 11 months ago

Done! I also added a reactive statement for this component and split variations into grid stories. Please, kindly review it again. 😄

Th1nkK1D commented 10 months ago

Thank you for the Hacktoberfest participation! Please fill up the form before 6 November 2023 to receive our limited-edition stickers.