wevisdemo / parliament-watch

Citizens are watching 👀
https://parliamentwatch.wevis.info
Other
61 stars 33 forks source link

Legislative process content 3/9: Bill status #42

Closed Th1nkK1D closed 1 year ago

Th1nkK1D commented 1 year ago

Scope

Only what is included in the screenshot

Screenshot_20231021-094907.png

View Figma

Starting point

  1. The page is available at /legislative-process (source: srv/routes/legislative-process)
  2. Put the content under the right heading.
  3. If there are images, export from Figma, optimize images with squoosh.app or ImageOptim, put it in /static/images/legislative-process with a meaning full name.
  4. If there is a duplicate UI, create a new component and put it in src/components/legislative-process
l3luescreen commented 1 year ago

Hi, Can I work on this one?

Th1nkK1D commented 1 year ago

Hi, if you run into an issue that <b> won't make the text bold. It is fixed in c572545cbeb7c13fbd836130ca871a4453d47f85 so please pull the latest commit from the main branch.

l3luescreen commented 1 year ago

Hi, I saw some of bold texts used font-weight: 600 in Figma. But styles in typography provide font-weight: 700. Should I follow typography or Figma?

Screenshot 2566-10-29 at 00 10 46 Screenshot 2566-10-29 at 00 24 57

This is font-weight: 600

Screenshot 2566-10-29 at 00 12 00

This is font-weight: 700

Screenshot 2566-10-29 at 00 12 34

Also for , and also font-bold class that used font-weight: 700

Th1nkK1D commented 1 year ago

Hi, I saw some of bold texts used font-weight: 600 in Figma. But styles in typography provide font-weight: 700. Should I follow typography or Figma?

Sorry for the confusion, we have 2 headings set for typography. This one here is the fixed-heading which we refer to it as heading, not a fluid-heading that is responsive.

image image

So you can add a font-weight of 600 according to Figma. I think for tailwind it is font-semibold.

Th1nkK1D commented 1 year ago

Merged #59