wevisdemo / parliament-watch

Citizens are watching 👀
https://parliamentwatch.wevis.info
47 stars 26 forks source link

Legislative process content 8/9: Voting type and result #47

Closed Th1nkK1D closed 10 months ago

Th1nkK1D commented 11 months ago

Scope

Only what is included in the screenshot

Screenshot_20231021-095217.png

View Figma

Starting point

  1. The page is available at /legislative-process (source: srv/routes/legislative-process)
  2. Put the content under the right heading.
  3. If there are images, export from Figma, optimize images with squoosh.app or ImageOptim, put it in /static/images/legislative-process with a meaning full name.
  4. If there is a duplicate UI, create a new component and put it in src/components/legislative-process
tortrakul-won commented 10 months ago

Hi, I think I can do this one. Can I contribute to this issue?

If so, may I know the deadline?

tortrakul-won commented 10 months ago

image

Are these supposed to be list items <li>? The way they read is a bit unusual.

Th1nkK1D commented 10 months ago

Are these supposed to be list items <li>? The way they read is a bit unusual.

Yup it's li but in 2 column as a separated list. One for 'ไม่ลงคะแนน' and one for 'ลา/ขาดลงมติ'

tortrakul-won commented 10 months ago

This might be a stupid question, but I can't seem to create a new branch. Can you help me with this?

Th1nkK1D commented 10 months ago

This might be a stupid question, but I can't seem to create a new branch. Can you help me with this?

Without permission, no one except the owner can push a commit or create a new branch to the repo. This is for security reasons. You need to folk first, push to your own forked repo, then open the pull request. After that I can review and merge our repo.

Th1nkK1D commented 10 months ago

Merged #56