Highlight active section on scroll in legistrative process sidebar

wevisdemo / parliament-watch

Citizens are watching 👀

https://parliamentwatch.wevis.info

47 stars 26 forks source link

Highlight active section on scroll in legistrative process sidebar #53

Closed Th1nkK1D closed 9 months ago

Th1nkK1D commented 10 months ago

View Figma

Starting point

The Sidebar component was already implemented in /legislative-process page (source: src/routes/legislative-process/+page.svelte).
Add a logic that when user scroll into each section, the item in side bar is highlighted (like แนะนำภาพรวม from the screenshot)
- Can use scrollama to detect the section. See example in src/routes/politicians/[id]/+page.svelte that implement similar thing.
- Try isSelected props on the SideMenuItem component ref

ptsgrn commented 10 months ago

Hello again! Can I do this as my 3rd PR?

Th1nkK1D commented 10 months ago

@ptsgrn Hi any update regarding this? Please let me know if you don't have a plan to do it soon so I can pass this issue to another person.

ptsgrn commented 10 months ago

I'm deeply sorry, @Th1nkK1D, to say that I think I will no longer be working on this. Due to its complexity and my own limited availability, you can safely assign it to someone else. I deeply apologize for not addressing this issue promptly and for not completing it.

Th1nkK1D commented 10 months ago

@ptsgrn don't worry! And please fill out the form so we can send you a sticker for your previous contribution 🙌

svnnynior commented 10 months ago

hi hi, can i do this? :)

Th1nkK1D commented 9 months ago

Merged #64