fResult/#5 VoteCard Component

wevisdemo / parliament-watch

Citizens are watching 👀

https://parliamentwatch.wevis.info

47 stars 26 forks source link

fResult/#5 VoteCard Component #8

Closed fResult closed 11 months ago

fResult commented 11 months ago

[x] Create Component
[x] Create Histoire component document

VoteCard.story.svelte file - Passed result VoteCard.story.svelte file - Failed result VoteCard.story.svelte file - Candidate result

fResult commented 11 months ago

Overall, a very good PR. Thank you so much. Have a few comments and one strange issue on the story. The date is invalid when I choose a custom candidate name from the dropdown. Not sure if you can reproduce it.

I already fixed krub.\ But workaround fixing it a bit.\ (I cannot find the way to fix it from the root cause) 🥹 Fixed Code The result that works

Th1nkK1D commented 10 months ago

Thank you for the Hacktoberfest participation! Please fill up the form before 6 November 2023 to receive our limited-edition stickers.