wevisdemo / promise-tracker

Thai politicians and parties promise tracker
https://promisetracker.wevis.info
13 stars 5 forks source link

[component] Filter Panel #9

Closed Th1nkK1D closed 2 years ago

Th1nkK1D commented 2 years ago

image

Idea

Used by

mixth commented 2 years ago

Hi. I am pretty busy lately, so I cleared the assignee for others. Please do grab this if you have the capacity. Do let me know if this issue is too big, I'm considering separating this into multiple issues.

Here is what I've done so far.

I have implemented two sub-components called DropdownSelect and ToggleList for this component and data mocking them into FilterPanel.

Screen Shot 2022-06-07 at 3 40 32 PM

Both sub-components should be functional as intended in Figma.

Th1nkK1D commented 2 years ago

@mixth Very good job krub. I completed what was left and here is some suggestion

  1. If we need to create some element that can be clicked, using button is better than div for a11y and we don't need CSS for pointer curser.
  2. When handling form input, Vue prefers 2-way binding with v-model over value and on-change-handler props like React. For standard HTML input, the v-model is very straightforward. While using with the custom component, it's a combination of props and emits an event.

Thank you for your hard work as always krub 🎉