wevm / frog

Framework for Farcaster Frames 🐸
https://frog.fm
Other
423 stars 97 forks source link

Validation fails if protocol is different (http:// & https://) #205

Closed sammdec closed 6 months ago

sammdec commented 7 months ago

Describe the bug

In warpcast when adding a url e.g caststorage.com without the protocol it converts it to http://caststorage.com. When a frame shares that same url, it throws an error similar to https://github.com/wevm/frog/issues/180 because the protocol differs.

Link to Minimal Reproducible Example

https://warpcast.com/~/developers/frames?url=http://caststorage.com

Steps To Reproduce

Got to url above, click tx button and see error

Frog Version

0.7.13

TypeScript Version

^5.4.3

Check existing issues

Anything else?

No response

jxom commented 7 months ago

Does your host/reverse proxy pass a x-forwarded-proto header?

sammdec commented 7 months ago

What's the best way to find out (I'm using vercel)?

dalechyn commented 6 months ago

tested it, doesn't seem to be an issue now. warpcast adds https automatically.