Developer experience improvement: twice api key declaration - Githubissues

wevm / frog

Framework for Farcaster Frames 🐸

https://frog.fm

Other

408 stars 94 forks source link

Developer experience improvement: twice api key declaration #319

Closed JWMatheo closed 3 months ago

JWMatheo commented 3 months ago

Describe the bug

I'm using neynar as a hub AND as a middleware.

I have to declare twice my api key and it feels weird.

Suggestion:

Add a "hub" key into neynar (from frog/middleware)

Benefits:

get rid of one import
only one api key declaration

Link to Minimal Reproducible Example

No response

Steps To Reproduce

No response

Frog Version

0.9.3

TypeScript Version

^5

Check existing issues

[X] I checked there isn't already an issue for the bug I encountered.

Anything else?

No response

tmm commented 3 months ago

Added https://github.com/wevm/frog/commit/1012bd5c85d761f82bae2720ed153b58f5737abe#diff-d8aed8b8464aff240df9199627027c4e74335e52e7fb9a955223756dfd24daa6R210

JWMatheo commented 3 months ago

Ty!