wevm / frog

Framework for Farcaster Frames 🐸
https://frog.fm
Other
393 stars 79 forks source link

Button.Link breaks url #352

Closed waptik closed 1 month ago

waptik commented 1 month ago

Describe the bug

So i have this url that has an &next-page=/path(a way for softr app to redirect users to a page after login in ) but frog generates the url as https://example.com/magic-authentication?magic-token=xxxxxxxxx&next-page=%2Fpath instead of https://example.com/magic-authentication?magic-token=e14c43269d744516986509d1cad8eb76&next-page=%2Fpath and it's breaking url redirection

Link to Minimal Reproducible Example

No response

Steps To Reproduce

No response

Frog Version

0.8.7

TypeScript Version

No response

Check existing issues

Anything else?

No response

github-actions[bot] commented 1 month ago

Hello @waptik.

Please provide a minimal reproduction using StackBlitz, TypeScript Playground (for type issues), or a separate minimal GitHub repository.

Minimal reproductions are required as they save us a lot of time reproducing your config & environment, and trying to reproduce your issue. See Why reproductions are required.

Please reopen this issue when a reproduction is added.

dalechyn commented 1 month ago

Frog Version 0.8.7

You're using an outdated version of Frog, I believe this is fixed in https://github.com/wevm/frog/commit/913b0cb6da5de738118d35d767d0168295bc5b2d.

If upgrading doesn't help, please reopen the issue and add a minimal reproducible example.