search

wevm / viem

TypeScript Interface for Ethereum
https://viem.sh
Other
2.44k stars 729 forks source link

(simulate|write)Contract payable value not working for overloads #2531

Closed tmm closed 1 month ago

tmm commented 1 month ago

Check existing issues

Viem Version

2.17.11

Current Behavior

If an overloaded function has nonpayable and payable overloads, simulateContract and writeContract's value parameter is not inferred correctly for the payable overload.

Expected Behavior

Payable overload should allow value property.

Steps To Reproduce

No response

Link to Minimal Reproducible Example

https://www.typescriptlang.org/play/?target=99#code/JYWwDg9gTgLgBAbzgYygUwIYzQdQwG3zRgGF9g0A7GAGjgAsYYw6wMoBnNAQQCNg4AXzgAzKBBBwA5ADcKIKXAD0SuDACeYNBwBccAEwA6AIwB2E8YBQoSLERwA7lGDYSEalAzJacDqACu+Fhobh5e8MJiEtJyaCBK4cDuHIoqapraekZmFtbg0PBIIBjAlJTEQqLikrLySsj0JZQpyqoaWroGJubGVpbIyfDI5FTwALwo6MF4hMRkFNQAFAiWcHBeA-7UelIADAAeUjSrKI2lesWl5bQnMJ7NtjB6jMyLAJTHgm-9g+v8cBM2JwePxFgBtE5SERbbxJSi+DAiNAAFXuHCRUAAYtVFhgACZ49AcDh0fGE7QkuD+UowfQAVgAbG8jpDoZRYe4EUjURhmhjsRJcQSiZSySK6NTqPSGXReOpsBw3nA2OoMLwiCyALrfSxOFwhdx3cKLYYLHwrNZiik7A4sy38Y5rNkcygAOQwIDQOw4iJRaP51Tt6ygAHNOmC9vtDNGjtIDtHDLHjLtdpRNY7WnAAAIwDgAWjQ+y03gLUHEUBOMgI-i9cGMlE+3z1rkNnm8JpG1DoFvWwutccOGbVwAzzpgcPdnu9vp5fLQWMDQ9D4cjCdjq5jdGTqboG8T6cr1dr9cblksfhAgWCoSN7dNo27JytxJtg6fDpOY4nHtrUh93P9ecBQUJcwz0CN403Ac1y3FM0wzNIc3zQtixgUty0PfAaz0E9LC+c8AiCFswjvTtzSfPsXwHINh1HGFx3cSdf3-P1eXRIDFyfZdwL3ddIMTWCd2gmMDzWKssOPBs8O+IA

Anything else?

No response

github-actions[bot] commented 2 weeks ago

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Viem version. If you have any questions or comments you can create a new discussion thread.