wevm / viem

TypeScript Interface for Ethereum
https://viem.sh
Other
2.44k stars 729 forks source link

#2542 fix #2543

Closed tadad closed 1 month ago

tadad commented 1 month ago

fixes #2542 getChainId makes malformatted rpc requests


PR-Codex overview

This PR updates the getChainId function in getChainId.ts to use the eth_chainId method with JSON-RPC 2.0.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 1 month ago

@tadad is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: bf65781418d87767429e00b151d69eeac93b1612

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tadad commented 1 month ago

I have a feeling there are a lot more issues like this in viem, working on tracking them down

tadad commented 1 month ago

another one found in viem/actions/public/call.ts

jxom commented 1 month ago

See https://github.com/wevm/viem/issues/2542#issuecomment-2253471022