fix: erc6492 verification

wilsoncusack commented 1 month ago

DeploylessUniversalSigValidator.sol behavior does not currently match the spec, in that it does not call the factory if the account is already deployed.

According to the EIP, for the signer

... If the contract is deployed but not ready to verify using ERC-1271, wrap the signature as follows: concat(abi.encode((prepareTo, prepareData, originalERC1271Signature), (address, bytes, bytes)), magicBytes); prepareTo and prepareData must contain the necessary transaction that will make the contract ready to verify using ERC-1271 (e.g. a call to migrate or update)

and the verifier should call this "factory" with the calldata if the magic bytes are present

check if the signature ends with magic bytes, in which case do an eth_call to a multicall contract that will call the factory first with the factoryCalldata and deploy the contract if it isn’t already deployed; Then, call contract.isValidSignature as usual with the unwrapped signature

This PR currently just attempting to creating a broken test demonstrating the issue.

PR-Codex overview

Summary

Fixes ERC6492 verification and prepares for user operation gas estimation.

Detailed summary

Fixed ERC6492 verification in verifyHash.ts
Updated gas limits in estimateUserOperationGas.test.ts
Refactored code structure in verifyHash.test.ts
Added functionality for user operation in verifyHash.test.ts
Updated ABI and addresses in verifyHash.test.ts

The following files were skipped due to too many changes: src/constants/contracts.ts, src/account-abstraction/actions/bundler/prepareUserOperation.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}