wevote / Campaigns

America wins when more voters participate. Trying to win a race on election day? Running a voter registration drive? Start a campaign
MIT License
0 stars 3 forks source link

MUI 5 for Campaigns #149

Closed SailingSteve closed 2 years ago

SailingSteve commented 2 years ago

Similar changes for MUI 5 as with the WebApp Simplified TopNavigationAppBar (was TopNavigationDesktop) trying to eliminate an occasional spurious "Tabs.js:339 MUI: The value provided to the Tabs component is invalid." error. TopNavigationAppBar is a reference class for how to handle listeners in functional components. I haven't found the problem yet, but when you change to "More Campaigns" the app does a full page refresh, which leaves the Tab https://github.com/wevote/Campaigns/pull/1 temporarily undefined (causing the error). This doesn't appear to cause any harm, but there shouldn't be any red errors. Changed VoterPhotoUpload.jsx to a newer MUI 5 compatible library, fixed the FileReader listener console error. Stripped a bunch of webapp/cordova stuff out of SignInModal which simplified use of styled-components, and simplified its use of AppObservableStore. Still need to upgrade the Google Analytics to match WebApp Still need to upgrade sign in with twitter, to the new fast way

DaleMcGrew commented 2 years ago

👍