Closed DaleMcGrew closed 7 years ago
Sure. I would like to get basic Webhook data flowing first -- at that point all the data in postgres would stay current, including subscription expiration status.
This has been implemented
Hi Steve, I took a closer look at "move_donations_between_donors" in donate/models.py and it only seems to be moving entries from the DonationJournal. We need to move/update data from DonateLinkToVoter, DonationFromVoter, DonationLog, and DonationSubscription.
Thank you @SailingSteve for your recent check in that finishes cancelling donations and refunding subscriptions. Will you have time to work on this issue next?
Still cleaning up existing code, but I will get to this next.
@DaleMcGrew
If this needs more work, I would be happy to do it.
Thank you Steve, these changes look great. Feel free to remove the tables/classes that you think we don't need. So you are saying that DonationJournal is the only donation table with voter data? If so we can close this issue.
DonationJournal is the only table we need. DonationPlanDefiniton is still used, but is vestigial. If it were worth it, it could be removed with a few hours of work. Closing for now.
Please create a function in donate/controller.py called "move_donation_info_to_another_voter". Please call this function near the bottom of "voter_merge_two_accounts_for_api" in voter/controllers.py. This function should result in donations and donation history information that are spread across two voters to be merged into a single voter:
Let's discuss problem cases that might arise.