Closed masterjacy01 closed 1 month ago
[!CAUTION]
Review failed
The pull request is closed.
The changes encompass updates to various files, primarily enhancing the functionality and documentation of the service. Key modifications include the introduction of a new dependency for managing progress metadata, the addition of methods for checking entry existence and saving progress, and improvements to API documentation for vault-related endpoints. New schemas and services for progress metadata management have also been established, along with updates to existing methods to improve efficiency and error handling.
File Path | Change Summary |
---|---|
README.md |
Added a section detailing the Swagger documentation endpoint /docs with a link to access it. |
src/aggregators/operations-aggregator/operations-aggregator-helpers/arrakis-operations-helper.service.ts |
Modified ArrakisOperationsHelperService to include ProgressMetadataDbService , added checkIfEntryExists method, and updated logic in getFromBlocks to retrieve the last processed block number. |
src/aggregators/operations-aggregator/operations-aggregator.service.ts |
Updated OperationsAggregatorService to include ProgressMetadataDbService , enhanced processLogs for concurrent processing, added saveProgress method, and modified getLowestFromBlocks to call getFromBlocks from arrakisVaultOperationsHelperService . |
src/api/vaults/vaults.controller.ts |
Added API documentation annotations for /tvl/:address and /price/:address endpoints, including details on parameters and expected responses, and introduced a timeframe query parameter. |
src/database/database.module.ts |
Introduced ProgressMetadata schema and ProgressMetadataDbService , updated module imports and exports to include new service and schema. |
src/database/db-models.ts |
Added ProgressMetadataDto class with a constructor for address, lastBlockNumber, and aggregationType. |
src/database/progress-metadata/progress-metadata-db.service.ts |
Created ProgressMetadataDbService for managing progress metadata, including methods getLastBlockNumber and saveProgressMetadata . |
src/database/schemas/ProgressMetadata.ts |
Introduced ProgressMetadataDocument and ProgressMetadataSchema for storing progress metadata, with a unique compound index on address and aggregation type. |
src/database/vault-db/vault-db.service.ts |
Added checkIfEntryExists method to check for existing entries and changed logging levels for empty data conditions from error to warn . |
src/dto/HistoricPriceDto.ts |
Updated example value for timestamp in HistoricPriceDatapoint from string to number. |
src/dto/HistoricTvlDto.ts |
Updated example value for timestamp in HistoricTvlDatapoint from string to number. |
src/shared/enum/AggregationType.ts |
Introduced AggregationType enum with a member VAULT_COLLECTED_FEES_EVENT . |
README.md
file that provides information about the Swagger documentation, similar to the main PR's focus on enhancing documentation for the API.🐰 In the meadow, changes sprout,
New paths for logs, no doubt!
Progress tracked with care and glee,
Vaults now sing in harmony.
With docs that guide, and methods bright,
Our code hops forward, pure delight! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
and more little improvements, added more swagger docs also
Summary by CodeRabbit
Release Notes
New Features
/tvl/:address
and/price/:address
endpoints, including newtimeframe
query parameter.Bug Fixes
Documentation
Chores