search

wewewe718 / QrAndBarcodeScanner

An Android app for scanning QR codes and barcodes
The Unlicense
712 stars 141 forks source link

Adding Portuguese baseline and Portuguese (Portugal) #106

Closed ner00 closed 2 years ago

ner00 commented 2 years ago

The baseline is added to serve other Portuguese-speaking users not immediately covered by the Brazilian or European variants, like Angola or Mozambique.

I just now noticed the Transifex project, do you want me to cancel this PR and go through Transifex? I'm fairly familiar with its, but since this seems to be the first implementation of this particular language maybe you can pull directly?

Thanks for the awesome work!

prsnbrg commented 2 years ago

Hi! Please add the translations in values-* via Transifex.

Everything else looks good to me.

ner00 commented 2 years ago

I have requested but haven't been accepted to the translation team so far.

Since the language/s is in a blank state the project manager over at Transifex could as well just import the files, but if not I'll gladly go over the painstaking task of adding them manually, all I really need it to have translation access to the languages involved.

ner00 commented 2 years ago

Now in Transifex project page: https://www.transifex.com/a-302/qr-barcode-scanner/

prsnbrg commented 2 years ago

You can add the changes and additions in /fastlane/metadata/android/ to the repo via a pull request.

ner00 commented 2 years ago

Hi! Please add the translations in values-* via Transifex.

This turned out to be terrible advice, given that the translation work from Transifex was completely ignored, and in fact, only those pushed through here were actually ever pulled and merged into the actual release.

I've pushed https://github.com/wewewe718/QrAndBarcodeScanner/pull/128/files to reflect this inconsistency in the README since it is also inaccurate as to the mechanics of merging new translations, or updates to existing ones for that matter.