search

wewewe718 / QrAndBarcodeScanner

An Android app for scanning QR codes and barcodes
The Unlicense
741 stars 142 forks source link

Add option to clear history automatically after some time #88

Open rugk opened 3 years ago

rugk commented 3 years ago

use case

Often in your history you may forget passwords or so or you just want a clean history without entries from last year.

Proposed solution

Let me clean old history entries automatically after some time, e.g. two weeks or one or two months. Of course that should be optional.

More info

Even e.g. Firefox for Android does have an option to close tabs automatically. This is similar.

lucasnz commented 3 years ago

If I understand the request correctly. I have written the code to do this. This commit adds a setting screen so that history older than x days is automatically deleted. Happy for the commit to be copied into the main app: https://github.com/lucasnz/QrAndBarcodeScanner/commit/3fb76c57e834ab1b1c809dd6c51f0a808eada068

rugk commented 3 years ago

Yeah, thanks a lot, I guess a PR would be very appreciated!

The only thing that could be improvable is how you select the TimeSpan there. A field for days to enter is not really user-friendly (UX-wise), as I guess many could want to enter bigger values. And you just don't need to exact values IMHO nor do you need to force the user to calculate that in days.

As for inspiration I could point you to the given example from Firefox again: https://support.mozilla.org/en-US/kb/auto-close-open-tabs-firefox-android (maybe just add a "two weeks entry").