wework / grabbit

A lightweight transactional message bus on top of RabbitMQ
Apache License 2.0
98 stars 20 forks source link

When a saga instance is not found in the saga store do not reject the message #196

Closed rhinof closed 4 years ago

rhinof commented 4 years ago

In this case we should not return an error but rather log a Warn/Info and return nil There are edge cases in which the instance can be nil due to completion of the saga on a different node or worker. In cases like these returning an error here would prevent additional handlers to be invoked as the message will get rejected and transactions will be rolledback