search

wework / ray

Resources for building interfaces with WeWork's design system
https://ray.wework.com
Apache License 2.0
55 stars 13 forks source link

feat(tabs): add / modify tabs component #232

Closed gmharrison closed 2 years ago

gmharrison commented 5 years ago

Adds tabs component

Desktop: https://cl.ly/7a3cbd4d9991

Mobile: https://cl.ly/55c0ea0ab4f0

seimithwework commented 5 years ago

How are we dealing with accessibly by chance? Also, do we want the interactivity here and not in core-react?

https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html https://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-2/tabs.html

Also, we worked on the Tabs in product-core and we used buttons for the tabs for actual tabbing. When we spoke to @danaballasy and simon she said that the tab length should conform to the length of the string inside the button (aka tab) and to allow for the tabs to scroll of it gets longer.