search

wework / ray

Resources for building interfaces with WeWork's design system
https://ray.wework.com
Apache License 2.0
55 stars 13 forks source link

feat(grid): add product grid to ray product #233

Closed Morgantheplant closed 4 years ago

Morgantheplant commented 4 years ago

https://jira.weworkers.io/browse/WEB-754

Moves the Container, Grid, and Cell over from core-components.

I also updated the jest config in ray product-react to also check .tsx, .ts, and .jsx extensions. It looks like the tests weren't running on the tsx files.

Packages added: enzyme-to-json - for snapshots to run similar to core-components identity-obj-proxy - for stubbing out css modules in tests

The code here was mostly untouched except for swapping out classnames package for clsx

Morgantheplant commented 4 years ago

added @/preset-typescript to root bc I was failing when ran from root (not from the ray-product directory). Then it was failing bc of scss import error so I added identity-obj-proxy to root as well. Tried removing it from the ray-product directory but that would fail locally, so added it back in there.

wuweiweiwu commented 4 years ago

and the CI issue is because when you're referencing @wework/ray-product-react in the test it isn't built yet.

https://github.com/wework/ray/blob/master/packages/product-react/package.json#L5

Morgantheplant commented 4 years ago

closing in favor of https://github.com/wework/ray/pull/234