Closed ashelkovnykov closed 2 years ago
Looks good. Only a few more questions above, then I'll approve and merge. Thank you.
GH isn't showing it well, but I pushed a new version of the final commit. It fixed the typo for "129 fragments or more", fixed inconsistent usage of "additional"/"total" to "remaining", and added a little more explanation to the fragment header.
Includes:
Notes: A partially-complete version of Seguro Phase II that follows the design outlined in the proposal more closely is available on a different branch in my fork. It is trivial to
git cherry-pick
orgit rebase
the two branches together. However, I think the version included in this PR is the one we should go with.