wey-gu / nebula-up

One-liner NebulaGraph playground with allllllllll-in-one toolchain integrated on single Linux Server
https://siwei.io/nebula-up
63 stars 16 forks source link

spark container name diff #25

Closed liuxiaocs7 closed 2 years ago

liuxiaocs7 commented 2 years ago

I execute the statement just as follow:

# Install Core with Spark Connector, Nebula Algorithm, Nebula Exchange
curl -fsSL nebula-up.siwei.io/all-in-one.sh | bash -s -- v3 spark

The container name is spark-master-1 rather than spark_master_1?

image

And here maybe confusing.

wey-gu commented 2 years ago

Thanks, @liuxiaocs7 indeed, the different naming conventions were used in different env from my own ones, I'll do some study(on when/how it differentiated) and fix this soon

liuxiaocs7 commented 2 years ago

I think the docker-compose.yaml in spark folder has no container name specified for master. If that's true, I'll try to fix it.

  master:
    networks:
      - nebula-net
    volumes:
      - '${PWD}/:/root'
    image: 'bde2020/spark-master:2.4.5-hadoop2.7'
wey-gu commented 2 years ago

you are right, explicitly specify its container_name should do the job(to avoid naming convention), welcome to your PR :). Thanks! I suggest following a similar naming principle of other containers with container_name, that is no space or connecting char like sparkmaster, I'll update my blog posts accordingly after your pr merged.

background:

azureuser@nebula-up:~$ docker-compose version
docker-compose version 1.29.0, build 07737305
docker-py version: 5.0.0
CPython version: 3.7.10
OpenSSL version: OpenSSL 1.1.0l  10 Sep 2019
azureuser@nebula-up:~$ docker compose version
Docker Compose version v2.5.0
azureuser@nebula-up:~$ docker version
Client: Docker Engine - Community
 Version:           20.10.16
 API version:       1.41
 Go version:        go1.17.10
 Git commit:        aa7e414
 Built:             Thu May 12 09:17:23 2022
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          20.10.16
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.17.10
  Git commit:       f756502
  Built:            Thu May 12 09:15:28 2022
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.4
  GitCommit:        212e8b6fa2f44b9c21b2798135fc6fb7c53efc16
 runc:
  Version:          1.1.1
  GitCommit:        v1.1.1-0-g52de29d
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0