search

weyoss / redis-smq

A simple high-performance Redis message queue for Node.js.
MIT License
588 stars 64 forks source link

Config format not backwards compatible between version 1.0.22 and 1.1.1 #34

Closed SingHo2016 closed 4 years ago

SingHo2016 commented 4 years ago

We recently updated our redis-smq Node package from 1.0.22 to 1.1.1, and our consumers and producers started to fail because it would attempt to connect to 127.0.0.1 instead of the address specified in our config. Our config file looks like this:

module.exports = { namespace: 'dpp-redis-server', redis: { host: 'our.host.here', port: 6379 }, log: { enabled: 1 }, monitor: { enabled: true, host: '127.0.0.1', port: 3000, }, };

We noticed that the example config file in the repo has a slightly different configuration than version 1.0.22. Once we updated the config file, then it works as expected.

However, the biggest issue is that npm updates from 1.0.22 to 1.1.1 without expecting breaking API changes.

Could you look into adding backwards compatibility between configs from version 1.0 into 1.1?

weyoss commented 4 years ago

Thank you for reporting the issue. A new release is out. Please upgrade.