search

wez / wezterm

A GPU-accelerated cross-platform terminal emulator and multiplexer written by @wez and implemented in Rust
https://wezfurlong.org/wezterm/
Other
17.86k stars 800 forks source link

briefly gives incorrect size at launch (tiling window manager) #1115

Open Anomalocaridid opened 3 years ago

Anomalocaridid commented 3 years ago

What Operating System(s) are you seeing this problem on?

Linux Wayland

WezTerm version

wezterm 20210906-110516-86f0bae1

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

When I launch WezTerm in Sway and if its window does not take up the whole workspace, then zsh gets an inaccurate column count briefly at launch. I do not have this issue when using another terminal such as xfce4-terminal.

To Reproduce

Linux Distro: EndeavourOS Sway Shell: zsh 5.8 (x86_64-pc-linux-gnu)

  1. In a .zshrc put the following code at or near the top:
echo $(tput cols)
sleep 1
echo $(tput cols)
  1. Open WezTerm in Sway, with tiling set to vertical and at least one other window of any kind already open in the same workspace.

Both commands should output different numbers of columns, despite the window not visibly changing. The sleep command gives the terminal a generous amount of time to catch up so that the second command outputs a more accurate number. Running the same commands after the shell's startup will give the expected results.

Configuration

no config

Expected Behavior

I expected the number of columns reported to not change or at least to change quickly enough that it would not affect any command ran on terminal startup.

Logs

21:31:14.550 INFO wezterm_mux_server_impl::local > setting up /run/user/1000/wezterm/gui-sock-124555 21:31:14.605 INFO wezterm_gui::termwindow > OpenGL initialized! Radeon RX 580 Series (POLARIS10, DRM 3.41.0, 5.13.13-arch1-1, LLVM 12.0.1) 4.6 (Compatibility Profile) Mesa 21.2.1 is_context_loss_possible=false wezterm version: 20210906-110516-86f0bae1 21:35:00.042 WARNING wezterm_term::terminalstate > unhandled XtermKeyMode OtherKeys Some(1) 21:35:00.042 WARNING wezterm_term::terminalstate::performer > unknown unspecified CSI: "22t" 21:35:29.212 WARNING wezterm_term::terminalstate::performer > unknown unspecified CSI: "23t" 21:35:29.212 WARNING wezterm_term::terminalstate > unhandled XtermKeyMode OtherKeys Some(0) 21:35:33.128 INFO wezterm_gui::frontend > Ding! (this is the bell)

Anything else?

This affects other commands that rely on the terminal's number of columns, such as toilet -t. Toilet is a program that turns text into large ASCII art text, similar to figlet, and the -t flag makes its output fit to the terminal's width.

wez commented 3 years ago

Please try the latest nightly; it's possible that this was fixed by #1112

Anomalocaridid commented 3 years ago

Sorry for taking so long to get back to you. I have installed what I believe is currently the latest WezTerm nightly build: wezterm 20210919-182757-8f0ab02b. My problem does not appear to be resolved.

wez commented 2 years ago

Could you try the latest nightly? There have been a couple more fixes around startup window size and updating the size in the pty that may have resolved this

Anomalocaridid commented 2 years ago

The nightly resolved it, but seemingly only when the terminal's opened in an empty workspace or in a workspace where the only window is a tabbed container.

It's still a significant improvement in my opinion and I appreciate you letting me know about the recent fixes.