wez / wezterm

A GPU-accelerated cross-platform terminal emulator and multiplexer written by @wez and implemented in Rust
https://wezfurlong.org/wezterm/
Other
17.81k stars 798 forks source link

`text_background_opacity` doesn't work on win11 #1325

Closed meijieru closed 2 years ago

meijieru commented 2 years ago

What Operating System(s) are you seeing this problem on?

Windows

WezTerm version

wezterm 20210814-124438-54e29167

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

No, and I'll explain why below

Describe the bug

With the following config, it doesn't have any effect when I change the text_background_opacity

text_background_opacity=0.1 image text_background_opacity=1.0 image

To Reproduce

  1. Use the config below.
  2. Varies text_background_opacity

Configuration

window_background_image = "D:\\document\\nextcloud\\picture\\comic\\EVA_OneHalfLight.jpg",
  window_background_image_hsb = {
    brightness = 1.0,
    hue = 1.0,
    saturation = 1.0,
  },

  window_background_opacity = 1.0,
  text_background_opacity = 0.1,

Expected Behavior

The background image should be more transparent when text_background_opacity goes down.

Logs

No response

Anything else?

No response

wez commented 2 years ago

text_background_opacity only affects cells whose background color is changed to something other than the default background color, so if text had its background color set to red, and you had set text_background_opacity = 0.5 then you'd see more of a pink color when using a white background image.

window_background_opacity controls the opacity for cells that have the default background color.

meijieru commented 2 years ago

It doesn't work either.

If I understand correctly, it should affect the background of Windows.old/ here.

text_background_opacity = 0.1 image

text_background_opacity = 1.0 image

In addition, how can I blend the background image and the background from colorscheme? I want the image to be opacity over the colorscheme background instead of the desktop for the visibility of texts.

meijieru commented 2 years ago

Also, window_background_opacity doesn't work if window_background_image is not set. In addition, change window_background_opacity=0.1 deteriorate the font rendering.

window_background_opacity=0.1 image

window_background_opacity=1.0 image

Update: window_background_opacity in range [0.95, 1.0] works, other doesn't.

wez commented 2 years ago

Please try the nightly build; there have been some fixes around opacity handling

meijieru commented 2 years ago

Please try the nightly build; there have been some fixes around opacity handling

Looking forward to it. How can I do it using scoop?

wez commented 2 years ago

I don't know if scoop knows how to get the nightly builds, but there are a number of other options here: https://wezfurlong.org/wezterm/install/windows.html

meijieru commented 2 years ago

In the nightly build, small window_background_opacity & text_background_opacity works. Though the fonts are still deteriorates.

window_background_opacity=0.15 image

wez commented 2 years ago

Could you try again with the latest nightly?

meijieru commented 2 years ago

Download the latest build from https://github.com/wez/wezterm/releases/download/nightly/WezTerm-windows-nightly.zip, still have the problem.

wez commented 2 years ago

OK, I think this is now actually fixed in the very latest nightly; please try it and let me know!

meijieru commented 2 years ago

Confirm that the problem is solved.

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.