wez / wezterm

A GPU-accelerated cross-platform terminal emulator and multiplexer written by @wez and implemented in Rust
https://wezfurlong.org/wezterm/
Other
17.28k stars 781 forks source link

XCursor not applying system theme #1655

Closed Riyyi closed 2 years ago

Riyyi commented 2 years ago

What Operating System(s) are you seeing this problem on?

Linux X11

WezTerm version

20220218-071628-85a8434e

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

I can't seem to get the cursor theme to work in the tab bar, the split resize cursor does seem to work correctly. wezterm-cursors

I have verified the themes settings with these commands:

$ find /usr/share/icons ~/.local/share/icons ~/.icons -type d -name "cursors"
/usr/share/icons/capitaine-cursors-light/cursors
/usr/share/icons/Adwaita/cursors
/usr/share/icons/capitaine-cursors/cursors
find: ‘/home/user/.local/share/icons’: No such file or directory
find: ‘/home/user/.icons’: No such file or directory
$ grep 'Xcursor.theme' ~/.config/xorg/Xresources
Xcursor.theme: capitaine-cursors-light
$ xprop -root | grep RESOURCE_MANAGER | perl -pe 's/\\n/\n/g' | grep -i cursor.theme
Xcursor.theme:\tcapitaine-cursors-light
$ grep 'cursor-theme-name' ~/.config/gtk-3.0/settings.ini
gtk-cursor-theme-name=capitaine-cursors-light
$ grep 'cursor-theme-name' ~/.config/gtk-2.0/gtkrc
gtk-cursor-theme-name="capitaine-cursors-light"

To Reproduce

I tried running the application with the following commands, but none of them made the theme apply:

$ wezterm
$ XCURSOR_THEME="capitaine-cursors-light" wezterm
$ XCURSOR_PATH="/usr/share/icons" wezterm
$ XCURSOR_PATH="/usr/share/icons" XCURSOR_THEME="capitaine-cursors-light" wezterm
$ XCURSOR_PATH="/usr/share/icons/capitaine-cursors-light" wezterm
$ XCURSOR_PATH="/usr/share/icons/capitaine-cursors-light/cursors" wezterm

This is on Arch Linux with the wezterm-nightly-bin AUR package.

Configuration

no config

Expected Behavior

To apply the correct theme in the tab bar.

Logs

$ wezterm
 2022-02-21T14:02:39.757Z INFO  wezterm_mux_server_impl::local > setting up /run/user/1000/wezterm/gui-sock-378704
 2022-02-21T14:02:39.800Z INFO  wezterm_gui::termwindow        > OpenGL initialized! Mesa Intel(R) HD Graphics 530 (SKL GT2) 4.6 (Compatibility Profile) Mesa 21.3.6 is_context_loss_possible=false wezterm version: 20220218-071628-85a8434e
$ WEZTERM_LOG=trace wezterm

full log output

Anything else?

I have read the commits in #524 and @wez's comment in #1061, but I couldn't figure it out.

Frikilinux commented 2 years ago

Maybe you can try adding the symlink top_left_arrow to left_ptr like the Breeze theme https://github.com/KDE/breeze/commit/6316df30a995812003df9c1f31f9162e28c2bbcc

Riyyi commented 2 years ago

That works, I dont know if its appropriate to have a fallback, or if I should close the issue.

wez commented 2 years ago

I think it's reasonable to add a fallback in load_themed that tries top_left_arrow and so on for the current original X11 names.

Riyyi commented 2 years ago

Just tested the nightly, it works!

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.