wez / wezterm

A GPU-accelerated cross-platform terminal emulator and multiplexer written by @wez and implemented in Rust
https://wezfurlong.org/wezterm/
Other
17.32k stars 781 forks source link

Gnome: Allow double click on title bar to maximize the window #2831

Open jankatins opened 1 year ago

jankatins commented 1 year ago

Is your feature request related to a problem? Please describe.

I'm used to double clicking the title bar of a gnome app (and also a mac one, but right now I'm an a GNOME laptop) to maximize a window. wezterm doesn't allow me that.

I think I remember not having that problem a while ago?

My gnome is configured to do this:

λ  gsettings get org.gnome.desktop.wm.preferences action-double-click-titlebar
'toggle-maximize'

Describe the solution you'd like

I would like to have a double click in the title bar maximize the wezterm window.

Describe alternatives you've considered

I could click the maximize button, but it's a much smaller target than the whole title bar. I can also use a custom key combo (WIN+UP in my case)

wez commented 1 year ago

Can you share more about the environment in which you are running?

If you are running in wayland mode with a compositor that doesn't support server side decorations (eg: Mutter doesn't), then you are out of luck. This kind of titlebar action is handled by the window manager/compositor. For Wayland with client-side decorations, there is no standard protocol for sharing this kind of window environment policy with the application, unless the application is a GTK program and happens to cheat and encode all the same logic on the client side.

I recommend enable_wayland=false to cause wezterm to run under XWayland instead, which will effectively enable server side decorations and should make this work again.

jankatins commented 1 year ago

Gnome reports that it is running Wayland and I run whatever debian gives me when I install gnome. So I'm probably out of luck, I guess?

λ  wmctrl -m
Name: GNOME Shell

I noticed that Chrome also is a bit sluggish: if my perception is not misleading me, I have to tripple click... gitkraken (an electron app) works on double click. No idea if that is actually running in a gtk window under the hood?

valpackett commented 1 year ago

happens to cheat and encode all the same logic on the client side

That's not cheating, that's kinda what you're supposed to do. Alacritty does implement that for example.

Miuler commented 1 year ago

With the configuration enable_wayland=false the redrawing in resize window is slow.

nyabinary commented 1 year ago

Same issue here: NixOS