search

wez / wezterm

A GPU-accelerated cross-platform terminal emulator and multiplexer written by @wez and implemented in Rust
https://wezfurlong.org/wezterm/
Other
16.65k stars 745 forks source link

should not change the terminal size when using hide_tab_bar_if_only_one_tab #3429

Open rfc1036 opened 1 year ago

rfc1036 commented 1 year ago

What Operating System(s) are you seeing this problem on?

Linux X11

Which Wayland compositor or X11 Window manager(s) are you using?

fvwm 2.7.0

WezTerm version

20230402-133613-7735602b

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

After setting config.hide_tab_bar_if_only_one_tab = true, if I open a second tab then the window is maintained to the same size but the terminal is resized vertically to make space for the tab bar (e.g. from 25 to 23 lines). I believe that the correct behavior should be to resize the window and keep the terminal at the original size.

To Reproduce

No response

Configuration

local wezterm = require 'wezterm' local config = {} config.hide_tab_bar_if_only_one_tab = true return config

Expected Behavior

No response

Logs

No response

Anything else?

No response

wez commented 1 year ago

That's not a bug, it's how it's designed to work.

It's potentially possible to add a configuration option to govern this, but trying to enforce the window size programmatically on Linux systems is a PITA because tiling window managers have their own thoughts on the size of the window.

Drllap commented 1 year ago

I'm running into the same thing (I think) but on windows: Here I have one tab open in full-screen: image Then I create another tab and the of goes out of full-screen mode (kind of but not really): image

The same thing happens if I have two tabs open and close one of them.

Going in and out of full-screen mode fixes it.

rfc1036 commented 1 year ago

Could this be solved with some Lua instead? I tried, but I am still not familiar with the callback APIs.

I see the point of tiling WMs, but they are a niche and I do not understand how anybody else would want to have their 80x25 terminal be shortened when adding a tab. :-)

Anyway, thank you for working on wezterm: I love its flexibility and I would like to switch to it, so I hope that there will be some solution for this issue.

wez commented 1 year ago

@Drllap please file a separate issue

Drllap commented 1 year ago

@Drllap please file a separate issue

Done: #3439