wez / wezterm

A GPU-accelerated cross-platform terminal emulator and multiplexer written by @wez and implemented in Rust
https://wezfurlong.org/wezterm/
Other
16.66k stars 745 forks source link

Window padding background follows background color of adjacent cell #4173

Open murtaza64 opened 1 year ago

murtaza64 commented 1 year ago

It would be a nice-to-have aesthetic enhancement for the background of the padding around the terminal to follow the background color of adjacent cells. This would make statuslines in programs like vim look marginally better.

Mockup screenshots

before:

image

after: image

Not experienced with building terminals so no idea how difficult or performance-intensive this would be, but I feel like it would look nice :) It would also be cool if this could be configurable per-edge (I would personally only use it for the left and right edges)

murtaza64 commented 1 year ago

I am bored so I will try my own hand at this before asking for the help of someone more experienced

wez commented 1 year ago

Thanks for the suggestion.

However, I'm not interested in taking a PR to implement this enhancement because that would make it difficult to later make changes to how panes are composited and/or allowing changing the font size of individual panes.

murtaza64 commented 1 year ago

I spent the evening implementing the feature (before reading your reply 😅), and the way I implemented it it only considers the outer window borders, not the border between panes. If you have time. I would love if you could take a look (#4175). I'll attach some screenshots there

quot commented 3 weeks ago

I would love to see this implemented. I really like using strong color schemes in TUI apps to know what is open at a glance. But having the padding color never change makes it really stand out.

This is with Helix's default theme: image

This is 100% a nitpick on my side, and I completely understand skipping this if it would create too much work, but I just wanted to show my support for the feature request.