search

wez / wezterm

A GPU-accelerated cross-platform terminal emulator and multiplexer written by @wez and implemented in Rust
https://wezfurlong.org/wezterm/
Other
17.91k stars 804 forks source link

Colored undercurl and underline on WSL2 / updated ConPTY #4400

Open lostl1ght opened 1 year ago

lostl1ght commented 1 year ago

Hello!

Is your feature request related to a problem? Please describe. No colored underline support on WSL2.

Describe the solution you'd like From my understanding this PR finally added colored underline support to ConPTY. Can you, please, update bundled ConPTY ~or guide me through updating it myself~?

Describe alternatives you've considered Ssh'ing to WSL2 which is a different can of worms. :(

Additional context Also, by the looks of it, the PR did not make into a release, so downloading OpenConsole.exe from release files does not work. Additionally, maybe this PR can clarify some details.

lostl1ght commented 1 year ago

I think I've figured it out.

I've followed build instructions here. I've built Release x64 CascadiaPackage using Visual Studio 2022, put conpty.dll and OpenConsole.exe from bin/x64/Release into Wezterm's folder and it just worked™.

Building the entire solution may fail but only conpty.dll and OpenConsole.exe are needed.

The result: image

chtenb commented 1 year ago

Would this also work for curly underline support in native windows?

lostl1ght commented 1 year ago

Looks like it would not.

Powershell run from wezterm: image

WSL: image

antoineco commented 12 months ago

@lostl1ght thanks for sharing! Is anything stopping you from updating the pre-built files at https://github.com/wez/wezterm/tree/6a58a5ce94f186884ec70a60b5afbd728521b1c5/assets/windows/conhost?

Parsifa1 commented 11 months ago

i tried use newest openconsole.exe and conpty.dll, But it doesn't seem to work

Pytness commented 7 months ago

@lostl1ght could you share which commit did you use to build it? Im having trouble replicating your results.

antoineco commented 6 months ago

For people who still follow this thread, the bundled copies of conpty.dll and OpenConsole.exe were both updated in https://github.com/wez/wezterm/commit/e7fe7c07da2da071d75c88ff3ae7a3c0e74d4f1f to the version that ships with Windows Terminal 1.19.240130002.

Undercurl seems to now be working without issues in WezTerm nightly, as showcased in the following discussion:

https://github.com/wez/wezterm/discussions/4989#discussioncomment-9445143