gui-sock-$PID socket handling errors

Enr1g commented 9 months ago

What Operating System(s) are you seeing this problem on?

Linux X11

Which Wayland compositor or X11 Window manager(s) are you using?

i3

WezTerm version

20231004-113117-11dec45f

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

First of all, thank you for wezterm.

Back to the subject. New wezterm process creates a unix socket in /run/user/$UID/wezterm. I encountered the following bugs / features related to this:

These sockets aren't getting cleaned up after graceful process termination (at least, immediately).
The corresponding symlinks (e.g. x11-:0-wtf-class) aren't getting cleaned up too. A little worse, I guess, cause you can get something like this when you're trying to select wezterm instance by class:

$ WEZTERM_UNIX_SOCKET="" wezterm cli --class='wtf-class' list
09:56:51.110  ERROR  wezterm > failed to connect to Socket("/run/user/1000/wezterm/gui-sock-1173356"): connecting to /run/user/1000/wezterm/gui-sock-1173356; terminating

Creating process with wezterm start --class="wtf-class" --always-new-process doesn't create x11-:0-wtf-class symlink.
The most annoying part. Trying to get wezterm instance by class automatically spawns wezterm-mux-server if no corresponding x11-:0-wtf-class symlink was found:

$ WEZTERM_UNIX_SOCKET="" wezterm cli --class='wtf-class' list
09:54:28.130  WARN   wezterm_client::client > While connecting to Socket("/run/user/1000/wezterm/sock"): connecting to /run/user/1000/wezterm/sock.  Will try spawning the server.
09:54:28.130  WARN   wezterm_client::client > Running: "/usr/bin/wezterm-mux-server" "--daemonize"
...

Starting another process is not something I was expecting when running the list command.

To Reproduce

No response

Configuration

no config

Expected Behavior

No response

Logs

No response

Anything else?

No response

ryoppippi commented 1 month ago

same

ryoppippi commented 3 weeks ago

I got the same issue.

When I run wezterm cli spawn with sudo, it works... I'm using macOS with wezterm 20240203-110809-5046fc22

wez / wezterm