wez / wezterm

A GPU-accelerated cross-platform terminal emulator and multiplexer written by @wez and implemented in Rust
https://wezfurlong.org/wezterm/
Other
16.77k stars 751 forks source link

Kitty Image Protocol on tmux #4531

Open marromlam opened 10 months ago

marromlam commented 10 months ago

What Operating System(s) are you seeing this problem on?

macOS

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

20230712-072601-f4abf8fd

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

Recently Kitty image protocol can be used inside tmux and within Kitty terminal it seems to work properly (I just tried a handful of times). However in Wezterm it is not working, it prints a bunch of symbols instead of the image.

To Reproduce

kitty +kitten icat image.jpg

Configuration

no config

Expected Behavior

Image shown in terminal window

Logs

No response

Anything else?

No response

wis commented 6 months ago

I think support for this is what Wez meant by "placeholder support, which might enable support to function in tmux", an item in the todo list, in #986.

When I tried rendering an image using Chafa in WezTerm on Windows, in tmux, using this command:

chafa --passthrough tmux --format kitty tweet.png

I got the following output, just question mark symbols: image

I got a similar output when substituting kitty in the command with sixels

AnonymouX47 commented 6 months ago

For the sake of others who might come across this issue...

It's nice to have this, yes... but I believe there are other aspects of the protocol that should (maybe need to) be worked on before this is done.

Thanks to Jon, who recently handled a lot of these in #4847. There's still #2422, for which some work is already going on in #4995.

Like @wis mentioned, this is already being tracked in the main issue. Hence, the maintainer(s) and others are aware.

It'd be good to be patient and allow things take proper course.

Thank you.


I got a similar output when substituting kitty in the command with sixels

Just to note... this is entirely unrelated to this issue and I suspect the issue isn't even with Wezterm, probably chafa or tmux.