wez / wezterm

A GPU-accelerated cross-platform terminal emulator and multiplexer written by @wez and implemented in Rust
https://wezfurlong.org/wezterm/
Other
17.82k stars 799 forks source link

Wezterm open outside vscode #4541

Closed TheElegantCoding closed 1 year ago

TheElegantCoding commented 1 year ago

What Operating System(s) are you seeing this problem on?

Windows

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

wezterm 20230408-112425-69ae8472

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

Maybe this issue is not related to wezterm, when I put windows in vscode the wezterm as a terminal it doesn't open correctly at the bottom of vscode, still, i want to make sure if i am running everything correctly

  "terminal.integrated.profiles.windows": {
    "Wezterm": {
      "path": "C:\\Program Files\\WezTerm\\wezterm.exe",
      "icon": "terminal-powershell"
    },
  }

When i launch the wezterm in vscode this happens, it doesn't fit in the terminal section of vscode it runs the terminal out of vscode, like executing the .exe

image

To Reproduce

No response

Configuration

local wezterm = require("wezterm")
local colorscheme = require("style.colorscheme")
local color = require("style.color")
local keybindings = require("config.keybindings")
local alpha = require("util.alpha")
require("config.tab_title")
require("config.home_title")

local font_primary = "CaskaydiaCove NF"

local function font(name, params)
    return wezterm.font(name, params)
end

return {
    font = font(font_primary),
    font_size = 12,
    colors = colorscheme,
    automatically_reload_config = true,
    window_background_opacity = 0.9,
    window_close_confirmation = "NeverPrompt",

    enable_tab_bar = true,
    hide_tab_bar_if_only_one_tab = true,
    use_fancy_tab_bar = true,
    tab_max_width = 32,
    show_tab_index_in_tab_bar = false,
    switch_to_last_active_tab_when_closing_tab = true,
    show_new_tab_button_in_tab_bar = false,
    disable_default_key_bindings = true,
    check_for_updates = true,
    keys = keybindings,

    window_padding = {
        left = 12,
        right = 12,
        top = 12,
        bottom = 12,
    },

    window_frame = {
        active_titlebar_bg = alpha(color.background.background_900, 0.9),
        inactive_titlebar_bg = alpha(color.background.background_900, 0.9),
        font = font(font_primary, { bold = true }),
        font_size = 10,
    },

    default_prog = { "pwsh.exe" },

    window_decorations = "RESIZE",
    inactive_pane_hsb = {
        saturation = 0.9,
        brightness = 0.8,
    },
}

Expected Behavior

No response

Logs

No response

Anything else?

No response

NikGovorov commented 1 year ago

It is an expected behaviour. VS Code expects a path to a shell not to a terminal emulator. For example cmd.exe, powershell.exe, pwsh.exe, bash.exe or bash, zsh, fish etc. Wezterm on the other hand is a standalone alternative to VS Code's integrated terminal (which is based on xtermjs) and is not supposed to run inside it.

TheElegantCoding commented 1 year ago

yeah you are right, thanks

github-actions[bot] commented 11 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.