default local_echo_threshold_ms 100 not set for default_ssh_domains() ?

[sedlund]

What Operating System(s) are you seeing this problem on?

Windows

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

wezterm 20240203-110809-5046fc22

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

The default for manually added ssh_domains sets local_echo_threshold_ms = 100 which leads to a nice experience on distant remotes.

although if I have a ~/.ssh/config and let default_ssh_domains() generate the struct for me, it does not set local_echo_threshold_ms .

Not sure if this is intended, as the experience isn't as nice.

I am using:

config.ssh_domains = wezterm.default_ssh_domains()
for _, dom in ipairs(config.ssh_domains) do
  dom.assume_shell = 'Posix'
  dom.local_echo_threshold_ms = 10
end

To add it without having to manually recreate my ~/.ssh/config in the wezterm.lua

To Reproduce

No response

Configuration

above

Expected Behavior

No response

Logs

No response

Anything else?

No response

[wez]

Thanks for the report; this is now fixed in main!

[github-actions[bot]]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.