search

wez / wezterm

A GPU-accelerated cross-platform terminal emulator and multiplexer written by @wez and implemented in Rust
https://wezfurlong.org/wezterm/
Other
14.83k stars 674 forks source link

Feature/search field arrows support #5549

Closed kenchou closed 2 weeks ago

kenchou commented 2 weeks ago

Related PR https://github.com/wez/wezterm/pull/5416

Impliment https://github.com/wez/wezterm/issues/3087#issue-1578427455

As a Rust beginner, I'm not sure if there are more convenient existing string handling functions.

@Mrreadiness

wez commented 2 weeks ago

Thanks for this; please see my comment in https://github.com/wez/wezterm/pull/5416#discussion_r1636592180 I think that we should refactor and reuse the line editing logic from termwiz for this.

kenchou commented 2 weeks ago

It's late at night in China, I will continue to study it tomorrow :)

kenchou commented 2 weeks ago

Closed. Due to the refactoring in PR #5416, the LineEditBuffer code is now cleaner and more reusable.