wez / wezterm

A GPU-accelerated cross-platform terminal emulator and multiplexer written by @wez and implemented in Rust
https://wezfurlong.org/wezterm/
Other
16.93k stars 762 forks source link

Wezterm quick select does not work correctly with paths containing // #5763

Closed j-xella closed 2 months ago

j-xella commented 3 months ago

What Operating System(s) are you seeing this problem on?

Windows

Which Wayland compositor or X11 Window manager(s) are you using?

not relevant

WezTerm version

20240624-065522-552bb1d6

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

Wezterm quick select mode comes with some patterns out of the box, for example to match git hashes or path names.

The latter does not work correctly, IMO. For example, the following 2 paths are equivalent:

However, wezterm's quick select mode will pick the former as one path, but the latter will only available as 2 paths: a/b and /c/d. I believe wezterm is supposed to recognise it as one path, because that's what it is.

To Reproduce

Configuration

don't define any additional quick_select_patterns

Expected Behavior

a/b//c/d is marked as one chunk and assigned single selection shortcut

Logs

No response

Anything else?

It is possible to manually create a new file matching patter, something like:

config.quick_select_patterns = {
  [[(?:[-._~/a-zA-Z0-9])*/(?:[-._~/a-zA-Z0-9]*)]], -- unix paths
}

But it seems like re-implementing functionality just to bypass a small bug - the bug should really be fixed.

github-actions[bot] commented 1 month ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.