search

wez / wezterm

A GPU-accelerated cross-platform terminal emulator and multiplexer written by @wez and implemented in Rust
https://wezfurlong.org/wezterm/
Other
14.89k stars 677 forks source link

Parse "include" directive in ssh configs #824

Closed strazto closed 3 years ago

strazto commented 3 years ago

Is your feature request related to a problem? Please describe.

My dotfiles are setup to have the following structure:

.ssh
├── config
├── config.d
│   ├── aws
│   ├── control.01.usyd -> /home/matty/.config/dotfiles/private-dotfiles/tools/ssh/config.d/control.01.usyd
│   ├── control.99.common -> /home/matty/projects/bash_bindings/bootstrap/tools/ssh/config.d/control.99.common
│   ├── cronnit -> /home/matty/.config/dotfiles/private-dotfiles/tools/ssh/config.d/cronnit
│   ├── server_connect -> /home/matty/.config/dotfiles/private-dotfiles/tools/ssh/config.d/server_connect
│   ├── server_ports -> /home/matty/.config/dotfiles/private-dotfiles/tools/ssh/config.d/server_ports
│   ├── usyd_config -> /home/matty/.config/dotfiles/private-dotfiles/tools/ssh/config.d/usyd_config
│   └── windows_ports -> /home/matty/.config/dotfiles/private-dotfiles/tools/ssh/config.d/windows_ports

~/.ssh/config has the following:

Include config.d/*

Everything in config.d is included.

Presently, wezterm doesn't touch anything but .ssh/config, as it doesn't handle the "Include". This means my ssh config isn't used properly.

Describe the solution you'd like

Please allow Include to be used

strazto commented 3 years ago

Nvm, just misspelled the hostname in config lmao

strazto commented 3 years ago

I'm not clear on which parts of ssh config actually get used - is Host & Hostname matched?

wez commented 3 years ago

The supported config items are listed in the docs: https://wezfurlong.org/wezterm/ssh.html I've just added Include handling in the nightly build!

strazto commented 3 years ago

Oh amazing!! I was getting ready to submit a PR (slowgoing bc Rust is new to me) but you beat me to the punch

I'm potentially still keen to request ProxyCommand/ProxyJump, so I'll save thay for another issue

strazto commented 3 years ago

Checked the docs, just saw proxycommand, i swear that wasn't there yesterday 🙏 Really excited to see how multiplexing goes on my remotes

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.