search

wf49670 / ppgen

Post-processing generator for DP
6 stars 4 forks source link

language attribute error #29

Closed ghost closed 10 years ago

ghost commented 10 years ago

ppgen generates <span LANG="fr" xml:LANG="fr"> and it needs to be "lang" to validate. Simple fix, listed here for continuity. Assigned to rfrank.

ghost commented 10 years ago

Fixed and pushed to master as it's a bug that needs immediate fixing. That also put all the other recent changes to develop into master. I know there is a way to do a hotfix and leave develop alone but I am not that competent with github yet. I also now have master slightly different than develop (master has a comment on the version line) and that was unintended.

wf49670 commented 10 years ago

I don't think that's related to anything I changed, but I should have noticed it and either mentioned or fixed it. Sorry.

It's only a problem in the develop branch, as far as I know.

Walt

ghost commented 10 years ago

The problem is in just moving too fast. I should have a proper regression test set up. That would have caught LANG in a heartbeat. No need to apologize for missing it. Far as I'm concerned anyone developing ppgen get's a "free pass" and if something gets posted that's wrong, it's on me as I'm the only one who can commit to the master branch.

Sometimes I wish ppgen were the only project on my plate so I could give it my full attention.

ghost commented 10 years ago

Ok I think develop and master are back in sync. I need a break. I'm going to McDonalds for a bacon, egg and cheese biscuit.