Allow compile on OSes where python2.5 is default

wfarr / nodenv

NodeJS version management. You know, for nodes.

MIT License

47 stars 13 forks source link

Allow compile on OSes where python2.5 is default #12

Closed rtgibbons closed 9 years ago

rtgibbons commented 11 years ago

On CentOS 5, python 2.5 is default with glibc 2.5. This requires a custom compilation of python.

./configure needs to be called by python2.6 or python2.7 to compile. make already picks up the environment variable

cronopio commented 9 years ago

Sounds reasonable. Someone else could mention if this change could break other environments? I'm on the road to release v0.3.4 but don't want to break any existing nodenv installation. If no answer will merge this on next monday. Thanks @rtgibbons for your contribution.

rtgibbons commented 9 years ago

No problem; My thoughts on this breaking other ENV's

It shouldn't. If $PYTHON is set for a users ENV; then it will use that version. If it's not set, then it will return an empty string, and ./configure will just get called as the spaces in front will just be ignored (at least in BASH and ZSH)

cronopio commented 9 years ago

Ok cool. I think same. Lets merge this.