search

wfarr / nodenv

NodeJS version management. You know, for nodes.
MIT License
47 stars 13 forks source link

Verify download using sha1 checksum, if possible #23

Open stisti opened 9 years ago

stisti commented 9 years ago

Download also SHASUMS.txt file and check the downloaded tar package is good.

Apparently the older node versions do not have a SHASUMS.txt file, so do not fail, just warn, if the SHASUMS.txt cannot be downloaded.

cronopio commented 9 years ago

Hi

Thanks for the contribution, really appreciated. Would you try to rebase your branch to the latest master?

Also we added io.js support recently so not sure if we can do the same for io.js releases

Thanks!

stisti commented 9 years ago

Sure, will do.

2015-08-10 22:52 GMT+03:00 Daniel Aristizabal notifications@github.com:

Hi

Thanks for the contribution, really appreciated. Would you try to rebase your branch to the latest master?

Also we added io.js support recently so not sure if we can do the same for io.js releases

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/wfarr/nodenv/pull/23#issuecomment-129582923.

stisti commented 9 years ago

Here you go. I switched to using sha256 because that's what iojs seems to use.

cronopio commented 9 years ago

@stisti Aweomse. Thank you so much for taking the time. I'll review and merge ASAP.

Thanks!!