Closed Fra4prg closed 3 years ago
Mr no name, (I didn't see anything that looks like a name in your email).
I'm not a github expert, I only started using it in earnest with this project. But usually, when people want to submit code to a project, they generate a "pull request". Then I get an alert of the pull request, and review the changes, and then decide if I'll accept the code.
So I'd suggest researching how to do a pull request. I did one with the Sharango T-watch code, and it wasn't that hard to figure out.
I'll leave your issue open for now.
Bill Dudley
This email is free of malware because I run Linux.
On Fri, Jan 8, 2021 at 12:48 PM Fra4prg notifications@github.com wrote:
modfiles.zip https://github.com/wfdudley/T-watch-2020/files/5788652/modfiles.zip Hello Bill,
first of all thank you for this great project. It’s the best T-Watch I found so far.
I made some additions to the stop watch and I would appreciate if you could merge this into your project. Please apologise, I'm new to Github and it was a nightmare to configure everything but I still get an error when I try to push my branch: "remote:Permission to wfdudley/T-watch-2020.git denied to Fra4prg..." I don't know: Isn't it allowed to submit a branch to a foreign project? How else could I submit my proposal? I added my changed/added files here as modfiles.zip. All changes are marked with the comment // Fra4prg:
Description of my changes: Added "Smart Sound" option ("HeliTimer") "Smart Sound" enables you to hear the number of minutes without having to look on the display. The idea behind this is that human brain can identify the number of 3 beeps as triple without counting them even if they are very short and fast. So up to 3 beeps are played slowly and preceeding triples are faster. For every 10 minutes a sweep sound is preceeding. A new top left button switches modes between [no sound] - [vibration + sound] - [only sound]
Some examples to show the sequence: Minute 1: C5 Minute 2: C5-E5 Minute 3: C5-E5-G5 Minute 4: triple - C5 Minute 5: triple - C5-E5 ... Minute 9: triple - triple - C5-E5-G5 Minute 10: sweep ... Minute 18: sweep - triple - triple - C5-E5 and so on...
As you can see this works well for short times up to 10 minutes then it gets weird... The idea came up when I was flying model helicopters where I had to control the flight time due to small batteries and must not loose visual contact to my heli model. So I made a small Arduino based timer called HeliTimer. But this function fits perfect to the T-watch :-)
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wfdudley/T-watch-2020/issues/27, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI4VYUZPDGQATGZ3MQ7KC4DSY5AOBANCNFSM4V2YHMHA .
Oops! My name is Frank Scholl. Sorry that I missed to put my name here - very embarrassing 8-O Yes I tried a pull request but as I understood this requires a branch. Maybe creating a fork is the right way? I will investigate more on the pull request. Thank you for your patience.
Best regards Frank
Frank,
Yes, you create your own branch of the code in your github account, make your changes, and then do a pull request.
Bill
This email is free of malware because I run Linux.
On Sat, Jan 9, 2021 at 8:05 AM Fra4prg notifications@github.com wrote:
Oops! My name is Frank Scholl. Sorry that I missed to put my name here - very embarrassing 8-O Yes I tried a pull request but as I understood this requires a branch. Maybe creating a fork is the right way? I will investigate more on the pull request. Thank you for your patience.
Best regards Frank
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/wfdudley/T-watch-2020/issues/27#issuecomment-757167656, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI4VYU7A3RAOBC23V3O4EMTSZBICBANCNFSM4V2YHMHA .
Hi Bill,
I guess I managed to create my pull request via fork. If everything looks ok in this process you can close this issue.
Regards Frank
Thanks. I'll get to your pull request soon, but I was busy with another problem all weekend.
Bill Dudley
This email is free of malware because I run Linux.
On Mon, Jan 11, 2021 at 7:39 AM Fra4prg notifications@github.com wrote:
Closed #27 https://github.com/wfdudley/T-watch-2020/issues/27.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/wfdudley/T-watch-2020/issues/27#event-4190579297, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI4VYU7MFKEEPJELMV6LIDLSZLWPPANCNFSM4V2YHMHA .
modfiles.zip Hello Bill,
first of all thank you for this great project. It’s the best T-Watch I found so far.
I made some additions to the stop watch and I would appreciate if you could merge this into your project. Please apologise, I'm new to Github and it was a nightmare to configure everything but I still get an error when I try to push my branch: "remote:Permission to wfdudley/T-watch-2020.git denied to Fra4prg..." I don't know: Isn't it allowed to submit a branch to a foreign project? How else could I submit my proposal? I added my changed/added files here as modfiles.zip. All changes are marked with the comment // Fra4prg:
Description of my changes: Added "Smart Sound" option ("HeliTimer") "Smart Sound" enables you to hear the number of minutes without having to look on the display. The idea behind this is that human brain can identify the number of 3 beeps as triple without counting them even if they are very short and fast. So up to 3 beeps are played slowly and preceeding triples are faster. For every 10 minutes a sweep sound is preceeding. A new top left button switches modes between [no sound] - [vibration + sound] - [only sound]
Some examples to show the sequence: Minute 1: C5 Minute 2: C5-E5 Minute 3: C5-E5-G5 Minute 4: triple - C5 Minute 5: triple - C5-E5 ... Minute 9: triple - triple - C5-E5-G5 Minute 10: sweep ... Minute 18: sweep - triple - triple - C5-E5 and so on...
As you can see this works well for short times up to 10 minutes then it gets weird... The idea came up when I was flying model helicopters where I had to control the flight time due to small batteries and must not loose visual contact to my heli model. So I made a small Arduino based timer called HeliTimer. But this function fits perfect to the T-watch :-)