wffancy / 3dssg

3D scene graph generation using GCN
44 stars 8 forks source link

The pooling/aggregation section is not consistent with the paper #10

Closed PericlesHat closed 1 year ago

PericlesHat commented 1 year ago

Hi, thanks for your work. I found, probably, a mistake on your codes.

The pooling section in gcn.py is not consistent with the Equation 4 in the 3DSSG paper. What you did is accumulating the own features based on the degree of that certain node. I demonstrated it on colab: https://colab.research.google.com/drive/1vBmdTxMfL3wKdm2mckjPZcZZVdfXTQjL?usp=sharing

And here is the official aggregation codes from Wald's cohort work (I don't know whether it is consistent with the paper either) https://github.com/ShunChengWu/3DSSG/blob/69ad0818daaf7229fa193aeff4a608a34c189139/src/network_TripletGCN.py#LL70