search

wffranco / vue-strap

Bootstrap components built with Vue.js
http://wffranco.github.io/vue-strap/
MIT License
338 stars 132 forks source link

Tabs generated for list don't support removal of headers #111

Open sburnicki opened 7 years ago

sburnicki commented 7 years ago

When I generate tabs from a list like this:

  <tabs nav-style="tabs" v-model="activeTab">
    <tab v-for="(myTab) in myTabs" v-bind:header="myTab.name">
   ...

Then I can add and remove new tabs. However, on removal (like this.myTabs.splice(0, 1)) the headers don't get properly updated.

I guess this is because they are explicitly added on created, but not being removed in beforeDestroy in the Tab component

laurenswarson commented 7 years ago

Same error!

Toilal commented 7 years ago

Same here.

Toilal commented 7 years ago

I wrote a Pull Request, but i'm not sure this repository is still maintained :(