search

wfg / docker-openvpn-client

OpenVPN client with killswitch and proxy servers; built on Alpine
MIT License
353 stars 107 forks source link

fix detection when AUTH_SECRET is empty #108

Open cpainchaud opened 1 year ago

wfg commented 1 year ago

In which situations does the original test not work?

On Tue, May 23, 2023 at 6:51 AM Christophe Painchaud < @.***> wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/wfg/docker-openvpn-client/pull/108 Commit Summary

File Changes

(1 file https://github.com/wfg/docker-openvpn-client/pull/108/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/wfg/docker-openvpn-client/pull/108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFJCPA4BDECCLOJTZN5YCHLXHSQERANCNFSM6AAAAAAYLYULGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

cpainchaud commented 1 year ago

If I put no AUTH_SECRET when I created the container (I put credentials in the opvn config file) then this test will fail and will force the use of --auth-user-pass" "/run/secrets/$AUTH_SECRET" which is obviously why this test was put in place I guess

for the record this is how I create my container:

  --network docker1 \
  --name=openvpn \
  --cap-add=NET_ADMIN \
  --device=/dev/net/tun \
  --volume /xxxxxxxxx/config:/config \
  --restart unless-stopped \
  -e ALLOWED_SUBNETS=xxxxxx/24 \
  -e CONFIG_FILE=default.ovpn \
  -e TZ=Europe/Paris \
  ghcr.io/xxxxxxx/openvpn-client
cpainchaud commented 1 year ago

any new on this one @wfg ?

thank you