wfondrie / depthcharge

A deep learning toolkit for mass spectrometry
https://wfondrie.github.io/depthcharge/
Apache License 2.0
59 stars 18 forks source link

Incorporate Wout's suggestions #37

Closed wfondrie closed 1 year ago

wfondrie commented 1 year ago

Small PR to incorporate @bittremieux review from the past merge. It also adds learnable wavelengths for the float and peak encoders.

codecov[bot] commented 1 year ago

Codecov Report

Merging #37 (83da967) into main (4d6a0a7) will decrease coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   91.50%   91.48%   -0.02%     
==========================================
  Files          19       19              
  Lines         965      963       -2     
==========================================
- Hits          883      881       -2     
  Misses         82       82              
Impacted Files Coverage Δ
depthcharge/data/parsers.py 96.96% <ø> (ø)
depthcharge/data/preprocessing.py 100.00% <ø> (ø)
depthcharge/data/spectrum_datasets.py 93.12% <ø> (ø)
depthcharge/feedforward.py 100.00% <ø> (ø)
depthcharge/tokenizers/peptides.py 68.65% <ø> (ø)
depthcharge/encoders/sinusoidal.py 100.00% <100.00%> (ø)
depthcharge/transformers/peptides.py 94.54% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more