Closed Alfred-N closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
2079903
) 92.48% compared to head (e7e08d8
) 92.48%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @Alfred-N 👏
Linting is failing due to a change in the Ruff CLI args, not necessarily due to a linting problem in the PR. I'm going to patch this real quick and push to this PR.
Looks good now! Merging. 🎉
.with_suffix(.lance)
was being called on the str path instead of the pathlib object, causing a crash if the "path" arg is given to the__init__
of SpectrumDatasetSecondly, the
.suffix
attribute includes the dot, hence the if statement should compare ifif self._path.suffix != ".lance"
instead ofif self._path.suffix != "lance"