wfondrie / mokapot

Fast and flexible semi-supervised learning for peptide detection in Python
https://mokapot.readthedocs.io
Apache License 2.0
43 stars 15 forks source link

Replace logging.[...] with LOGGER.[...] #105

Closed RalfG closed 1 year ago

RalfG commented 1 year ago

Simply replacing some log calls to the root logger (logging) to the module-level logger (LOGGER). Not sure if there were specific reasons to keep these log calls on the root logger. If there were, please ignore this PR :)

wfondrie commented 1 year ago

These were indeed unintentional - thanks for catching and fixing them!

codecov[bot] commented 1 year ago

Codecov Report

Merging #105 (16e505f) into main (da2d545) will decrease coverage by 0.37%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   85.36%   85.00%   -0.37%     
==========================================
  Files          19       19              
  Lines        1640     1640              
==========================================
- Hits         1400     1394       -6     
- Misses        240      246       +6     
Files Changed Coverage Δ
mokapot/brew.py 91.15% <50.00%> (-3.54%) :arrow_down:
mokapot/model.py 86.47% <50.00%> (-0.97%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

:loudspeaker: Have feedback on the report? Share it here.

wfondrie commented 1 year ago

It looks like I need to fix the codecov action. It's helpful but it has been the most annoying tool to keep working on my projects 🤔

I'm going to go ahead and merge.