Add workflow for building Windows installer

wfondrie / mokapot

Fast and flexible semi-supervised learning for peptide detection in Python

https://mokapot.readthedocs.io

Apache License 2.0

41 stars 15 forks source link

Add workflow for building Windows installer #111

Open RalfG opened 11 months ago

RalfG commented 11 months ago

This PR partially addresses #101:

pyinstaller.spec instructs PyInstaller to freeze mokapot with all its dependencies (including Python) in an executable.
innosetup.iss instructs InnoSetup to bundle everything in a Windows Installer exe.
I extended .github/workflows/publish.yml to go through the above two steps and upload the exe as an asset to the release.

What is still needed to fully implement #101:

[ ] Run PyInstaller on macOS
[ ] Find a way to bundle the frozen package into a macOS installer
[ ] Run PyInstaller on Linux (not sure which distros are needed?)
[ ] Find a way to bundle the frozen package into a Linux installer for each distro

I don't have any experience with these open issues, so I leave them open for someone else to tackle.

codecov[bot] commented 11 months ago

Codecov Report

Merging #111 (1cc33b2) into main (6725bdc) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   85.36%   85.36%           
=======================================
  Files          19       19           
  Lines        1640     1640           
=======================================
  Hits         1400     1400           
  Misses        240      240

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jspaezp commented 10 months ago

Hey there!

IMO linux and mac don't really need an installer, distributing the executable has been good enough in my experience. I am fixing the actions to allow t his to go though and will check on the mac side of things.

jspaezp commented 10 months ago

https://github.com/jspaezp/mokapot/actions/runs/6710019031/job/18234321059 My local branch fails due to a relative import ... I think we might need to modify that.

RalfG commented 1 week ago

Hi @jspaezp,

I rebased the branch to the latest changes on main. However, I might wait for #125 to be merged before continuing here, as this PR also updates the actions.

Regarding the relative imports: It seems like they would all need to be updated. Is there a reason relative imports (e.g. from .brew import brew are used instead of absolute ones (e.g. from mokapot.brew import brew)?

Best, Ralf