search

wfondrie / mokapot

Fast and flexible semi-supervised learning for peptide detection in Python
https://mokapot.readthedocs.io
Apache License 2.0
41 stars 15 forks source link

added support for subset > data size #39

Closed jspaezp closed 3 years ago

jspaezp commented 3 years ago

The only thing missing would be making sure the warning is thrown by the cli implementation to the log ... not sure how to do that ...

discussed https://github.com/wfondrie/mokapot/issues/38

wfondrie commented 3 years ago

Thanks! This looks good to me for the most part, I opened PR #40 with a couple small updates.

The only thing missing would be making sure the warning is thrown by the cli implementation to the log ... not sure how to do that ...

Anything put through the logging module is fortunately handled automatically. 👍

Please check the "allow edits from maintainers" box next time, so that we can keep it all in on PR. (GitHub can be annoying in that way sometimes! 😛)

jspaezp commented 3 years ago

sorry about that :P i thought that was enabled by defaults