wfondrie / mokapot

Fast and flexible semi-supervised learning for peptide detection in Python
https://mokapot.readthedocs.io
Apache License 2.0
43 stars 15 forks source link

fix non-deterministic multi-threading and reproduce results using trained models #52

Closed sambenfredj closed 2 years ago

sambenfredj commented 2 years ago
codecov-commenter commented 2 years ago

Codecov Report

Merging #52 (0b229ac) into master (91e6f96) will decrease coverage by 0.05%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   83.09%   83.04%   -0.06%     
==========================================
  Files          18       18              
  Lines        1538     1551      +13     
==========================================
+ Hits         1278     1288      +10     
- Misses        260      263       +3     
Impacted Files Coverage Δ
mokapot/brew.py 86.40% <75.00%> (-1.77%) :arrow_down:
mokapot/config.py 91.30% <100.00%> (+0.19%) :arrow_up:
mokapot/model.py 83.83% <100.00%> (ø)
mokapot/mokapot.py 85.36% <100.00%> (+0.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91e6f96...0b229ac. Read the comment docs.

wfondrie commented 2 years ago

Thanks for this PR @sambenfredj! We'll just need to add unit tests that cover the changes for the code coverage checks to pass.

sambenfredj commented 2 years ago

Hi @wfondrie, I added tests for the new cli argument and the brew function which fixed the pipelines :)

sambenfredj commented 2 years ago

Thanks !